Add parentheses around thread id to prevent diff flamegraph #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of the --thread option can result in stack samples that look like "thread <thread_id> <count>". Inferno and Brendan Gregg's perl script will treat this as a frame function of with name "thread" and two counts. This results in the creation of differential flamegraph when not desired. Changing the frame name to "thread (<thread_id>)" fixes this issue.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the --thread option can result in stack samples that look like
thread <thread_id> <count>. Inferno and Brendan Gregg's perl script will treat this as a function with namethreadand two counts. This results in the creation of a differential flamegraph when notdesired. Changing the frame name to
thread (<thread_id>)fixes thisissue. Note this is only an issue when there are no stack frames on top of the thread root (ie.
thread <thread_id>; A (file.py:123) <count>is no problem). Below I've attached a zip with 4 profiles, 2 before the change and 2 after to demonstrate the issue.example_files.zip